Add MPFS250 QSPI support #677
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgarske
force-pushed
the
polarfire_soc_qspi
branch
2 times, most recently
from
633e7f8 to
5e963dc
Compare
danielinux
requested changes
Feb 3, 2026
Member
danielinux
left a comment
danielinux
left a comment
There was a problem hiding this comment.
Looks good, some minor visibility issues
hal/mpfs250.h
Outdated
| * System Controller Mailbox API (public) | ||
| * ============================================================================ */ | ||
| #ifndef __ASSEMBLER__ | ||
| /* Returns non-zero if mailbox is busy */ |
Member
There was a problem hiding this comment.
Is there a reason why this API is public? Will these functions be used by other modules outside mpfs250.c ?
hal/mpfs250.c
Outdated
| } | ||
|
|
||
| /* Wait for flash to be ready (poll status register) */ | ||
| int qspi_wait_ready(uint32_t timeout_ms) |
hal/mpfs250.c
Outdated
| } | ||
|
|
||
| /* Send Write Enable command */ | ||
| int qspi_write_enable(void) |
hal/mpfs250.c
Outdated
| } | ||
|
|
||
| /* Read JEDEC ID from flash */ | ||
| int qspi_read_id(uint8_t *id_buf) |
hal/mpfs250.c
Outdated
| * data_len: Length of data phase | ||
| * dummy_cycles: Number of idle cycles between command and data phase | ||
| */ | ||
| int qspi_transfer_block(uint8_t read_mode, const uint8_t *cmd, uint32_t cmd_len, |
hal/mpfs250.c
Outdated
| * Returns: non-zero if busy, 0 if ready | ||
| */ | ||
| static int mpfs_scb_mailbox_busy(void) | ||
| int mpfs_scb_is_busy(void) |
Member
There was a problem hiding this comment.
See the comment in .h -- if those become internal to the mpf250.c module, these functions starting with mpfs_ should become static.
dgarske
force-pushed
the
polarfire_soc_qspi
branch
from
5e963dc to
2f8ce14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Key Changes
config/examples/polarfire_mpfs250_qspi.confighal/mpfs250.c(MSS QSPI + SC SPI paths)arch.mkfor update loader selection + ELF signingdocs/Targets.mdtools/scripts/mpfs_program.shTesting